Explicitly declare default goals in Makefiles #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2024 08:57
setup-env.mk is included before the "frontend" goal is defined and because we were not explicitly naming it as the default goal, the 1st goal in setup-env.mk became the implicit default goal.
setup-env.mk is included before the "backend" goal is defined and because we were not explicitly naming it as the default goal, the 1st goal in setup-env.mk became the implicit default goal.
geoberle
approved these changes
Dec 4, 2024
bennerv
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
setup-env.mkis now included before the "frontend" or "backend" goal is defined infrontend/Makefileandbackend/Makefilerespectively, and because we were not explicitly naming those as the default goal, the 1st goal insetup-env.mkbecame the implicit default goal.